Fixed library install from git-url when reference points to a git branch #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmaglie merged 3 commits into arduino:master from cmaglie:fix_git_install

Feb 11, 2025

Merged

Fixed library install from git-url when reference points to a git branch #2833

cmaglie merged 3 commits into arduino:master from cmaglie:fix_git_install

Feb 11, 2025

Conversation

cmaglie

Copy link

Member

@cmaglie cmaglie commented Feb 7, 2025

Please check if the PR fulfills these requirements

See how to contribute

The PR has no duplicates (please search among the Pull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes library install from git-url when reference points to a git branch.

What is the current behavior?

Using the --git-url option with a specific branch gives error

Error installing Git Library: Library install failed: reference not found

What is the new behavior?

Library installs correctly

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Fix #2825

cmaglie added 2 commits

February 7, 2025 14:50

@cmaglie


 Added integration test

da51907

@cmaglie


 Fixed library install from git when ref points to a branch

f73e3f1

@cmaglie cmaglie added type: enhancement topic: code labels

Feb 7, 2025

@cmaglie cmaglie self-assigned this

Feb 7, 2025

@cmaglie


 Praise linter

ef4a5f4

@cmaglie cmaglie requested a review from a team

February 7, 2025 14:11

@codecov Codecov

Copy link

codecov bot commented Feb 7, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (a2eebcd) to head (ef4a5f4).
Report is 10 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@
## master #2833 +/- ##
==========================================
+ Coverage 67.74% 67.76% +0.02% 
==========================================
 Files 238 238 
 Lines 22410 22402 -8 
==========================================
 Hits 15181 15181 
+ Misses 6034 6029 -5 
+ Partials 1195 1192 -3