Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upgrade some golang packages #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 6 commits into arduino:master from cmaglie:upgrade_libs
Dec 24, 2024
Merged

Upgrade some golang packages #2792

cmaglie merged 6 commits into arduino:master from cmaglie:upgrade_libs
Dec 24, 2024

Conversation

Copy link
Member

@cmaglie cmaglie commented Dec 19, 2024
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Upgrade the following packages:

  • golang.org/x/*
  • go.bug.st/serial
  • github.com/go-git/go-git/v5

Upgrading go-git required a change in the git-URL parsing function (actually it has been completely reworked).

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Dec 19, 2024
@cmaglie cmaglie self-assigned this Dec 19, 2024
Previously go-git accepted urls in the format:
 https://github.com/author/repo#ref
but now it refuses to fetch if the "#ref" suffix is present.
The new parsing utility returns the URL cleaned up of the reference.
Copy link

codecov bot commented Dec 20, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.63%. Comparing base (d1cc322) to head (b69ab5a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@
## master #2792 +/- ##
==========================================
+ Coverage 67.59% 67.63% +0.04% 
==========================================
 Files 238 238 
 Lines 22373 22392 +19 
==========================================
+ Hits 15122 15144 +22 
+ Misses 6062 6060 -2 
+ Partials 1189 1188 -1 
Flag Coverage Δ
unit 67.63% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 4cdf367 into arduino:master Dec 24, 2024
102 checks passed
@cmaglie cmaglie deleted the upgrade_libs branch December 24, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

1 more reviewer

@alessio-perugini alessio-perugini alessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /