Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(fqbn): implement json and sql interface #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lucarin91 wants to merge 4 commits into arduino:master
base: master
Choose a base branch
Loading
from lucarin91:add-json-sql-on-fqbn

Conversation

Copy link
Contributor

@lucarin91 lucarin91 commented Dec 16, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Copy link

CLAassistant commented Dec 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (fff8658) to head (f65c41c).

Files with missing lines Patch % Lines
pkg/fqbn/sql.go 0.00% 14 Missing ⚠️
pkg/fqbn/json.go 0.00% 13 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #2785 +/- ##
==========================================
- Coverage 67.76% 67.69% -0.07% 
==========================================
 Files 238 240 +2 
 Lines 22402 22429 +27 
==========================================
+ Hits 15181 15184 +3 
- Misses 6029 6054 +25 
+ Partials 1192 1191 -1
Flag Coverage Δ
unit 67.69% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /