-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fixed protoc.zip release artifact missing google/rpc/status.proto
#2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
November 21, 2024 12:20
@cmaglie
cmaglie
added
topic: infrastructure
Related to project infrastructure
type: imperfection
Perceived defect in any part of project
labels
Nov 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2761 +/- ## ========================================== - Coverage 67.55% 67.53% -0.03% ========================================== Files 237 237 Lines 22358 22358 ========================================== - Hits 15105 15100 -5 - Misses 6063 6066 +3 - Partials 1190 1192 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
alessio-perugini
alessio-perugini
approved these changes
Nov 21, 2024
umbynos
umbynos
approved these changes
Nov 21, 2024
giacomocusinato
added a commit
to arduino/arduino-ide
that referenced
this pull request
Nov 22, 2024
..._{version}_proto.zip`
- Use the CLI release proto.zip to get proto files for production versions of CLI
- Extract the proto files from repo if CLI version is declared as `commitsh` or version is 1.1.0
See arduino/arduino-cli#2761
giacomocusinato
added a commit
to arduino/arduino-ide
that referenced
this pull request
Nov 22, 2024
..._{version}_proto.zip`
- Use the CLI release proto.zip to get proto files for production versions of CLI
- Extract the proto files from repo if CLI version is declared as `commitsh` or version is 1.1.0
See arduino/arduino-cli#2761
4 tasks
giacomocusinato
added a commit
to arduino/arduino-ide
that referenced
this pull request
Nov 27, 2024
..._{version}_proto.zip`
- Use the CLI release proto.zip to get proto files for production versions of CLI
- Extract the proto files from repo if CLI version is declared as `commitsh` or version is 1.1.0
See arduino/arduino-cli#2761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
It uses the
buf exportfunction to produce the protoc.zip artifact content.bufwill automatically include all the dependencies.What is the current behavior?
The export was missing the
google/rpc/status.protoWhat is the new behavior?
Future exports will have the missing
google/rpc/status.protofile again.Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fix #2755