Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Added option to disable integrity checks in core install (for development purposes) #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 4 commits into arduino:master from cmaglie:core_unsafe_install
Jan 14, 2025

Conversation

Copy link
Member

@cmaglie cmaglie commented Oct 29, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

We have added a new configuration option, board_manager.enable_unsafe_install, to allow the installation of platforms/tools that do not pass the checksum test. This option has been added to ease the platform's development phase, relieving the developer from having to regenerate the index every time, and is not intended for use in production environments.

What is the current behavior?

If a platform fails the checksum test, it will not be installed:

$ arduino-cli core install GD32Community:gd32
Downloading packages...
[...]
Installing platform GD32Community:gd32@0.0.1...
Error during install: Cannot install platform: installing platform GD32Community:gd32@0.0.1: testing local archive integrity: testing archive checksum: missing checksum for: ArduinoCore-GD32-main.zip
$

What is the new behavior?

The checksum test may be skipped:

$ ARDUINO_BOARD_MANAGER_ENABLE_UNSAFE_INSTALL=true arduino-cli core install GD32Community:gd32 
Tool GD32Community:xpack-arm-none-eabi-gcc@9.3.1-1.3 already installed
Tool GD32Community:xpack-openocd@0.11.0-1 already installed
Tool GD32Community:dfu-util@0.10.0-arduino1 already installed
Downloading packages...
GD32Community:gd32@0.0.1 downloaded 
Installing platform GD32Community:gd32@0.0.1...
Configuring platform....
Platform GD32Community:gd32@0.0.1 installed
$

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #1468

per1234 reacted with heart emoji
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.65%. Comparing base (bfbfdce) to head (4f3d245).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
commands/instances.go 25.00% 0 Missing and 3 partials ⚠️
commands/service_platform_upgrade.go 40.00% 2 Missing and 1 partial ⚠️
internal/arduino/resources/install.go 62.50% 2 Missing and 1 partial ⚠️
commands/service_library_install.go 33.33% 0 Missing and 2 partials ⚠️
.../arduino/cores/packagemanager/install_uninstall.go 80.00% 0 Missing and 2 partials ⚠️
internal/arduino/cores/packagemanager/profiles.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #2740 +/- ##
==========================================
- Coverage 67.67% 67.65% -0.03% 
==========================================
 Files 239 239 
 Lines 22408 22424 +16 
==========================================
+ Hits 15165 15170 +5 
- Misses 6049 6056 +7 
- Partials 1194 1198 +4
Flag Coverage Δ
unit 67.65% <68.75%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie self-assigned this Oct 29, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 29, 2024
@cmaglie cmaglie merged commit c78921a into arduino:master Jan 14, 2025
100 checks passed
@cmaglie cmaglie deleted the core_unsafe_install branch January 14, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

1 more reviewer

@alessio-perugini alessio-perugini alessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make size and checksum fields of package index optional

AltStyle によって変換されたページ (->オリジナル) /