-
-
Notifications
You must be signed in to change notification settings - Fork 422
Increased gRPC message size limit to 16MB / added CLI flag to set the value #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: gRPC
Related to the gRPC interface
labels
Oct 11, 2024
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
October 11, 2024 09:58
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #2729 +/- ## ========================================== - Coverage 67.68% 67.66% -0.02% ========================================== Files 234 234 Lines 22285 22298 +13 ========================================== + Hits 15083 15089 +6 - Misses 6017 6022 +5 - Partials 1185 1187 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
alessio-perugini
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
--max-grpc-recv-message-size <SIZE>flag todaemoncommandWhat is the current behavior?
gRPC message size limit is 4MB
What is the new behavior?
gRPC message size limit is 16MB
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #2718