-
-
Notifications
You must be signed in to change notification settings - Fork 423
Fix monitor init handling #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
October 10, 2024 16:17
@cmaglie
cmaglie
added
type: imperfection
Perceived defect in any part of project
topic: gRPC
Related to the gRPC interface
labels
Oct 10, 2024
umbynos
umbynos
approved these changes
Oct 10, 2024
...to terminate otherwise the test will fail on Windows when the cleanup function tries to remove the executable: Error Trace: D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:46 D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:56 D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:56 D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:62 D:/a/arduino-cli/arduino-cli/internal/integrationtest/daemon/daemon_concurrency_test.go:127 Error: Received unexpected error: remove C:\Users\runneradmin\AppData\Local\Temp\cli2489057723\A\packages\builtin\tools\serial-monitor0円.14.1\serial-monitor.exe: Access is denied. Test: TestInitAndMonitorConcurrency
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2728 +/- ## ======================================= Coverage 67.68% 67.68% ======================================= Files 234 234 Lines 22285 22285 ======================================= Hits 15083 15083 Misses 6017 6017 Partials 1185 1185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
alessio-perugini
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fix a deadlock in the gRPC
Monitorcommand that keeps the package manager busy for no reason.What is the current behavior?
While a call to gRPC
Monitorcommand is running, other calls may be blocked, in particular theInitcall. This lead to the Arduino IDE bug described in #2719What is the new behavior?
The
Monitorcommand doesn't lock the package manager anymore.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #2719