-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix Debug* gRPC function calls implementation
#2672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: imperfection
Perceived defect in any part of project
topic: gRPC
Related to the gRPC interface
labels
Jul 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #2672 +/- ## ========================================== - Coverage 70.25% 70.05% -0.20% ========================================== Files 222 221 -1 Lines 21362 21422 +60 ========================================== Hits 15007 15007 - Misses 5176 5236 +60 Partials 1179 1179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@cmaglie
cmaglie
changed the title
(削除) Fix Debug* gRPC function calls implementation (削除ここまで)
(追記) Fix Jul 22, 2024
Debug* gRPC function calls implementation (追記ここまで)
@cmaglie
cmaglie
force-pushed
the
fix_grpc_functioncalls
branch
from
August 7, 2024 09:50
147e255 to
d14711e
Compare
This a challenging problem because we must wait on both an io.Read(...) and a channel-read but, unfortunately, go native select can wait only on channels. To overcome this limitation I had to resort to a conditional variable and write some boilerplate code to make everything synchronized.
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
August 7, 2024 22:58
alessio-perugini
alessio-perugini
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Makes the gRPC implementation of
Debugin par with the rest of the gRPC API.What is the current behavior?
No change
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
While technically this is a breaking change, it's fixing an API implementation, so I'm going to pass it as a bugfix.
Other information