-
-
Notifications
You must be signed in to change notification settings - Fork 423
Improved {build.*.platform.path} vars enumeration.
#2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2652 +/- ## ========================================== - Coverage 70.26% 70.23% -0.04% ========================================== Files 222 222 Lines 21343 21348 +5 ========================================== - Hits 14996 14993 -3 - Misses 5161 5176 +15 + Partials 1186 1179 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
egnor
commented
Jun 26, 2024
(kibitz: build.use_core_platform_for_runtime_platform_path might not be quite right, since it doesn't just affect the build but in fact just about any variable, including upload and so on?)
egnor
commented
Jul 17, 2024
(This seems to work, by the way! -- see #2616 (comment) -- is it likely to land any time soon?)
(kibitz:
build.use_core_platform_for_runtime_platform_pathmight not be quite right, since it doesn't just affect the build but in fact just about any variable, including upload and so on?)
Uhm... ok I'll rename it to runtime.use_core_platform_path_for_runtime_platform_path.
(This seems to work, by the way! -- see #2616 (comment) -- is it likely to land any time soon?)
Yes, sorry for the long delay, I'm updating the docs right now, and it should be ready for the next release.
7af9663 to
5976053
Compare
5976053 to
7a5cf9d
Compare
7a5cf9d to
0b80ef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This is a tentative fix for #2616. The original issue provided an experimental platform that extends
esp32to experiment with.This PR adds the following template variables that will be available to compose recipes:
{build.core.platform.path}contains the path to the reference (build) platform{build.board.platform.path}contains the path to the board platformAlso, adds the input variable
build.use_core_platform_for_runtime_platform_pathto be set onboards.txtorplatform.txt:truethen the value of{runtime.platform.path}will be the path to the reference platform.!=true) the value of{runtime.platform.path}will be the path to the board platform (as it always has been)What is the current behavior?
The compile fails with an "extended" platforms
What is the new behavior?
Unfortunately, the compile still fails. Hopefully, this PR could help to resolve the remaining issues.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
/cc @egnor