Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[breaking] Renamed gRPC field cc.arduino.cli.commands.v1.PlatformRelease.type to types #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 1 commit into arduino:master from cmaglie:grpc_fix
May 30, 2024

Conversation

Copy link
Member

@cmaglie cmaglie commented May 30, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix the field name in a gRPC message. See #2504 for details.

What is the current behavior?

$ arduino-cli core list --json | jq '.platforms[4].releases."1.8.13"'
{
 "name": "Arduino SAMD (32-bits ARM Cortex-M0+) Boards",
 "version": "1.8.13",
 "type": [
 "Arduino"
 ],
 ...

What is the new behavior?

$ arduino-cli core list --json | jq '.platforms[4].releases."1.8.13"'
{
 "name": "Arduino SAMD (32-bits ARM Cortex-M0+) Boards",
 "version": "1.8.13",
 "types": [
 "Arduino"
 ],
 ...

Does this PR introduce a breaking change, and is titled accordingly?

Yes

Other information

Fix #2504

@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface labels May 30, 2024
@cmaglie cmaglie self-assigned this May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (81d517b) to head (fc56b44).

Additional details and impacted files
@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
 Coverage 70.30% 70.30% 
=======================================
 Files 222 222 
 Lines 21304 21304 
=======================================
 Hits 14977 14977 
 Misses 5151 5151 
 Partials 1176 1176 
Flag Coverage Δ
unit 70.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit b72f5ca into arduino:master May 30, 2024
@cmaglie cmaglie deleted the grpc_fix branch May 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini Awaiting requested review from alessio-perugini

@Xayton Xayton Awaiting requested review from Xayton

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[grpc] Revisit the PlatformRelease#type naming (or typing)
2 participants

AltStyle によって変換されたページ (->オリジナル) /