-
-
Notifications
You must be signed in to change notification settings - Fork 423
Updated documentation about arduino-cli integration options.
#2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've also tested the 2 examples on Ubuntu while having the daemon running. Everything is working flawlessly! 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2605 +/- ## ========================================== - Coverage 70.13% 70.12% -0.02% ========================================== Files 222 222 Lines 21124 21124 ========================================== - Hits 14816 14813 -3 - Misses 5132 5134 +2 - Partials 1176 1177 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fixed documentation about integration options for
arduino-cli.What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information
fix #2543