-
-
Notifications
You must be signed in to change notification settings - Fork 422
gRPC Compile will now fail if a platform core has been modified.
#2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
topic: gRPC
Related to the gRPC interface
labels
Feb 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2551 +/- ## ========================================== + Coverage 69.38% 69.45% +0.06% ========================================== Files 205 205 Lines 20162 20207 +45 ========================================== + Hits 13989 14034 +45 Misses 5050 5050 Partials 1123 1123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
alessio-perugini
suggested changes
Feb 26, 2024
alessio-perugini
alessio-perugini
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Before starting a compilation the platforms are checked for changes on the main files
boards.txt,platform.txt, andprogrammers.txt. If a change is detected, the compile fails with anInstanceNeedsReinitializationError.A gRPC client would need to perform a new
Initcall to update the in-memory structures, and retry the compile.What is the current behavior?
If a core platform file (
boards.txt,platform.txt, orprogrammers.txt) is modified, the compile is performed with the old files already loaded in memory, leading to #2523.What is the new behavior?
The compile fails with an
InstanceNeedsReinitializationError.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information