-
-
Notifications
You must be signed in to change notification settings - Fork 422
[skip-changelog] fix release CI #2546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2546 +/- ## ======================================= Coverage 69.39% 69.39% ======================================= Files 205 205 Lines 20162 20162 ======================================= Hits 13991 13991 Misses 5044 5044 Partials 1127 1127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@cmaglie @alessio-perugini I did a test release https://github.com/arduino/arduino-cli/releases/tag/v0.0.0-test-rc.1 s3 upload worked great: https://github.com/arduino/arduino-cli/actions/runs/7970151615/job/21757382963#step:11:1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The archive content looks good too.
Sorry guys for the mess I did
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
(削除) - [ ] Tests for the changes have been added (for bug fixes / features) (削除ここまで)(削除) - [ ] Docs have been added / updated (for bug fixes / features) (削除ここまで)(削除) - [ ]UPGRADING.mdhas been updated with a migration guide (for breaking changes) (削除ここまで)(削除) - [ ]configuration.schema.jsonupdated if new parameters are added. (削除ここまで)What kind of change does this PR introduce?
Fix CI
What is the current behavior?
The
create-releasestep is not able to authenticate with OIDC to properly obtain credentials.What is the new behavior?
I've moved the permission in the proper section, under the last job. I've also replaced the plugin used to upload file to s3 with the standard s3 commandline
Does this PR introduce a breaking change, and is titled accordingly?
no
Other information