-
-
Notifications
You must be signed in to change notification settings - Fork 422
Allow to specify the config file through ARDUINO_CONFIG_FILE env
#2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alessio-perugini
merged 2 commits into
master
from
2481-support-arduino_config-environment-variable-1
Jan 4, 2024
Merged
Allow to specify the config file through ARDUINO_CONFIG_FILE env
#2488
alessio-perugini
merged 2 commits into
master
from
2481-support-arduino_config-environment-variable-1
Jan 4, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alessio-perugini
alessio-perugini
linked an issue
Jan 4, 2024
that may be
closed
by this pull request
3 tasks
@alessio-perugini
alessio-perugini
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Jan 4, 2024
@alessio-perugini
alessio-perugini
marked this pull request as ready for review
January 4, 2024 12:09
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2488 +/- ## ========================================== + Coverage 68.83% 68.91% +0.07% ========================================== Files 204 204 Lines 20465 20465 ========================================== + Hits 14088 14104 +16 + Misses 5222 5211 -11 + Partials 1155 1150 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmaglie
cmaglie
approved these changes
Jan 4, 2024
@alessio-perugini
alessio-perugini
deleted the
2481-support-arduino_config-environment-variable-1
branch
January 4, 2024 14:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Add
ARDUINO_CONFIG_FILEenv var, which as the same behaviour of the--config-fileflag.What is the current behavior?
Currently an user can only specify a specifc config file through the usage of
--config-fileflag.It's not possible to specify the config file thorugh an env var.
What is the new behavior?
Adding the
ARDUINO_CONFIG_FILEis now possible to specify either a specifc config file or a directorycontaining the default configuration file.
If the cli is provied with both
--config-fileand the new env the flag takes precedence.Does this PR introduce a breaking change, and is titled accordingly?
no
Other information