-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix caching for libraries when installation folder differents from Name #2446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2446 +/- ## ======================================= Coverage 67.49% 67.49% ======================================= Files 211 211 Lines 20712 20712 ======================================= Hits 13980 13980 Misses 5590 5590 Partials 1142 1142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
topic: build-process
Related to the sketch build process
labels
Dec 4, 2023
cmaglie
cmaglie
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmaglie
cmaglie
force-pushed
the
fix_recompiling_libraries
branch
from
December 4, 2023 11:07
44ac874 to
5a9be69
Compare
cmaglie
added a commit
that referenced
this pull request
Dec 4, 2023
...me (#2446) * Fix caching for libraries when installation folder differents from Name * Prepare infra to add integration test * Added integration test --------- Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
The PR fixes a bug when a library was wrongly purged as "unused" during compilation since its containing folder differed from its Name field in
library.propertiesWhat is the current behavior?
When compiling for
mbed_gigacore any sketch includingRPC.h, libraryopenamp_arduinowill be recompiled every time. The library name isopenamp(without_arduino).What is the new behavior?
The library gets properly cached and recompilation is avoided on the next turn.
Does this PR introduce a breaking change, and is titled accordingly?
Other information