-
-
Notifications
You must be signed in to change notification settings - Fork 422
[BREAKING] Removed debugging_supported field from BoardDetails gRPC call
#2438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmaglie
merged 2 commits into
arduino:master
from
cmaglie:remove_debug_info_from_board_details
Nov 24, 2023
Merged
[BREAKING] Removed debugging_supported field from BoardDetails gRPC call
#2438
cmaglie
merged 2 commits into
arduino:master
from
cmaglie:remove_debug_info_from_board_details
Nov 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Nov 24, 2023
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
November 24, 2023 15:45
umbynos
umbynos
approved these changes
Nov 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2438 +/- ## ========================================== + Coverage 67.31% 67.40% +0.08% ========================================== Files 210 210 Lines 20574 20567 -7 ========================================== + Hits 13850 13863 +13 + Misses 5585 5571 -14 + Partials 1139 1133 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Dec 20, 2023
...PC call (arduino#2438) * Removed debugging_supported field from BoardDetailsResponse * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
The
debugging_supportedfield has been removed from gRPCcc.arduino.cli.commands.v1.BoardDetailsResponseandboard detailscommand in CLI.Since the possibility to debug is determined by:
the
board detailshas no sufficient information to determine it.If you need to determine if a specific selection of board + option + programmer supports debugging, use the gRPC call
cc.arduino.cli.commands.v1.GetDebugConfig: if the call is successful, it means that the debugging is supported.What is the current behavior?
What is the new behavior?
The
Debuggin Supportedfield is no more available.Does this PR introduce a breaking change, and is titled accordingly?
Yes.
Other information