-
-
Notifications
You must be signed in to change notification settings - Fork 422
feat: allow boards to change debug support via FQBN options #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
"debug.executable" must be present AND non-empty for debugging to be supported, allowing board overrides. Also, use the same logic in the details view and in the actual debug command implementation.
40aa4b2 to
957ceae
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #2436 +/- ## ========================================== + Coverage 67.28% 67.30% +0.01% ========================================== Files 210 210 Lines 20568 20573 +5 ========================================== + Hits 13840 13846 +6 + Misses 5588 5587 -1 Partials 1140 1140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the PR @pillo79!
After merging #2435 the "debugging supported" is much more complex to determine and it depends also on the programmer selected.
We agreed that the "debugging supported" should no longer be a property of the board.
You can determine if debugging is supported by calling GetDebugConfig (if the call succeeds then the debugging is supported).
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
"debug.executable" must be present AND non-empty for debugging to be supported, allowing board overrides. Also, use the same logic in the details view and in the actual debug command implementation.
What is the current behavior?
Debug support is enabled if any of the
txtfiles define a key nameddebug.executable, regardless of its contents, preventing overrides by board and/or menu optionsWhat is the new behavior?
"debug.executable" must be present AND non-empty for debugging to be supported, allowing board overrides. Also, use the same logic in the details view and in the actual debug command implementation.
Does this PR introduce a breaking change, and is titled accordingly?
No, it is backwards compatible (all cores using debug define the key to a valid string, cores without debug never define the key).
Other information
Tested with Arduino Nano ESP32 package.
Original
platform.txtalready contains:Lines added to
boards.txt:arduino-cli board details -b arduino-git:esp32:nano_nora --format jsondoes not includedebugging_supportedkey.arduino-cli board details -b arduino-git:esp32:nano_nora:USBMode=hwcdc --format jsonincludes"debugging_supported": true.