-
-
Notifications
You must be signed in to change notification settings - Fork 422
Allow empty configuration merging #2432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MatteoPologruto
MatteoPologruto
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
topic: gRPC
Related to the gRPC interface
labels
Nov 22, 2023
@MatteoPologruto
MatteoPologruto
force-pushed
the
marge-empty-config
branch
from
January 8, 2024 08:43
fcd9bee to
96de3f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2432 +/- ## ======================================= Coverage 68.85% 68.86% ======================================= Files 204 204 Lines 20465 20470 +5 ======================================= + Hits 14091 14096 +5 Misses 5220 5220 Partials 1154 1154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@MatteoPologruto
MatteoPologruto
linked an issue
Jan 8, 2024
that may be
closed
by this pull request
Closed
3 tasks
@MatteoPologruto
MatteoPologruto
requested review from
cmaglie,
alessio-perugini and
umbynos
January 8, 2024 14:15
alessio-perugini
alessio-perugini
approved these changes
Jan 8, 2024
umbynos
umbynos
approved these changes
Jan 11, 2024
cmaglie
cmaglie
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Code enhancement
What is the current behavior?
It is not possible to merge empty values to delete elements inside the configuration.
What is the new behavior?
It is possible to delete non-defaults elements inside the configuration using an empty value. A full json configuration must be passed to the merge command.
Does this PR introduce a breaking change, and is titled accordingly?
Other information