-
-
Notifications
You must be signed in to change notification settings - Fork 422
Added a compatibility trick in debug -I for toolchain.prefix key
#2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmaglie
merged 2 commits into
arduino:master
from
cmaglie:debug-backward-compatibibilty
Nov 15, 2023
Merged
Added a compatibility trick in debug -I for toolchain.prefix key
#2428
cmaglie
merged 2 commits into
arduino:master
from
cmaglie:debug-backward-compatibibilty
Nov 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key was ignored in older versions of the Arduino IDE. In the upcoming release (Arduino IDE 2.2.2) the key is used, but it was wrongly set to "arm-none-eabi-" when we actually want "arm-none-eabi". This patch ensure backward and forward compatibility.
@cmaglie
cmaglie
requested review from
umbynos,
ubidefeo,
alessio-perugini and
MatteoPologruto
November 15, 2023 15:18
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: CLI
Related to the command line interface
labels
Nov 15, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #2428 +/- ## ========================================== + Coverage 67.27% 67.33% +0.05% ========================================== Files 210 210 Lines 20523 20526 +3 ========================================== + Hits 13807 13821 +14 + Misses 5578 5566 -12 - Partials 1138 1139 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
alessio-perugini
approved these changes
Nov 15, 2023
cmaglie
added a commit
that referenced
this pull request
Nov 15, 2023
...hain.prefix` key (#2428) * Added a compatibility trick in "debug -I" for toolchain.prefix key The key was ignored in older versions of the Arduino IDE. In the upcoming release (Arduino IDE 2.2.2) the key is used, but it was wrongly set to "arm-none-eabi-" when we actually want "arm-none-eabi". This patch ensure backward and forward compatibility. * Fixed debug command
umbynos
added a commit
to arduino/ArduinoCore-mbed
that referenced
this pull request
Nov 15, 2023
With newer versions of the IDE this was causing problems. See arduino/arduino-cli#2428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
The
debug.toolchain.prefixkey was ignored in older versions of the Arduino IDE.In the upcoming release (Arduino IDE 2.2.2) instead the key is used, but in the older releases of the platforms it was wrongly set to
"arm-none-eabi-"when we actually want"arm-none-eabi".This patch ensures backward and forward compatibility.
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information