-
-
Notifications
You must be signed in to change notification settings - Fork 422
Add completion support to --profile
#2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alessio-perugini
alessio-perugini
added
the
type: enhancement
Proposed improvement
label
Nov 14, 2023
@alessio-perugini
alessio-perugini
force-pushed
the
add-completion-support-in-profiles
branch
2 times, most recently
from
November 14, 2023 17:46
0d8ca10 to
b497e0f
Compare
@alessio-perugini
alessio-perugini
marked this pull request as ready for review
November 14, 2023 17:47
@alessio-perugini
alessio-perugini
requested review from
cmaglie,
MatteoPologruto and
umbynos
and removed request for
cmaglie
November 14, 2023 17:47
@alessio-perugini
alessio-perugini
force-pushed
the
add-completion-support-in-profiles
branch
from
November 14, 2023 17:49
b497e0f to
07f0144
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #2426 +/- ## ========================================== + Coverage 67.27% 67.29% +0.01% ========================================== Files 210 210 Lines 20523 20544 +21 ========================================== + Hits 13807 13825 +18 - Misses 5578 5580 +2 - Partials 1138 1139 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
umbynos
umbynos
approved these changes
Nov 16, 2023
@alessio-perugini
alessio-perugini
deleted the
add-completion-support-in-profiles
branch
November 16, 2023 15:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information