-
-
Notifications
You must be signed in to change notification settings - Fork 422
make boards details JSON output deterministic #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alessio-perugini
merged 1 commit into
master
from
2209-please-make-the-json-output-of-board-details-deterministic
Nov 14, 2023
Merged
make boards details JSON output deterministic #2419
alessio-perugini
merged 1 commit into
master
from
2209-please-make-the-json-output-of-board-details-deterministic
Nov 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alessio-perugini
alessio-perugini
added
the
type: enhancement
Proposed improvement
label
Nov 14, 2023
@alessio-perugini
alessio-perugini
linked an issue
Nov 14, 2023
that may be
closed
by this pull request
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2419 +/- ## ========================================== - Coverage 67.25% 67.16% -0.09% ========================================== Files 210 210 Lines 20543 20539 -4 ========================================== - Hits 13817 13796 -21 - Misses 5591 5603 +12 - Partials 1135 1140 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@alessio-perugini
alessio-perugini
requested review from
cmaglie,
umbynos and
MatteoPologruto
November 14, 2023 10:56
@alessio-perugini
alessio-perugini
marked this pull request as ready for review
November 14, 2023 10:56
umbynos
umbynos
approved these changes
Nov 14, 2023
@alessio-perugini
alessio-perugini
deleted the
2209-please-make-the-json-output-of-board-details-deterministic
branch
November 14, 2023 11:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Make
programmers
andbuild_properties
deterministic in JSON output.What is the current behavior?
Now when performing
arduino-cli boards details ...
it produces a JSON that has some fields that contain values that are always randomly sorted.What is the new behavior?
Now the
arduino-cli boards details ...
output produces a JSON that is always deterministic. No more randomly sorted values in arrays 🤘Does this PR introduce a breaking change, and is titled accordingly?
Other information