-
-
Notifications
You must be signed in to change notification settings - Fork 422
Improved logging on GitHub Actions runners (using log folding commands) #2414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2414 +/- ## ========================================== + Coverage 67.15% 67.16% +0.01% ========================================== Files 210 210 Lines 20523 20523 ========================================== + Hits 13782 13785 +3 + Misses 5602 5600 -2 + Partials 1139 1138 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 Wow I didn't know this feature of GA!
Should we also remove the -v flag from the tests? Without that flag, only failing tests should print in the log.
go:test: desc: Run unit tests and the Go-based integration tests deps: - task: go:build dir: '{{default "./" .GO_MODULE_PATH}}' cmds: - | go test \ -v \ <------- remove this? -short \ -run '{{default ".*" .GO_TEST_REGEX}}' \ {{default "-timeout 20m -coverpkg=./... -covermode=atomic" .GO_TEST_FLAGS}} \ -coverprofile=coverage_unit.txt \ {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}} \ {{.TEST_LDFLAGS}}
Amazing!! 📁
Should we also remove the -v flag from the tests? Without that flag, only failing tests should print in the log.
That would be the optimal solution, but I like to have the full logs available.
BTW I'm merging this one as is for now, I'd like to see if I can report errors in the "summary" page with this: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
-vflags fromgo buildcommand to avoid printing hundreds of package name being build, clogging up the log with useless information.What is the current behavior?
What is the new behavior?
image
Does this PR introduce a breaking change, and is titled accordingly?
Other information
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines