-
-
Notifications
You must be signed in to change notification settings - Fork 424
[breaking] Remove gRPC settings service
#2411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: gRPC
Related to the gRPC interface
labels
Nov 8, 2023
3 tasks
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
November 8, 2023 10:43
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2411 +/- ## ======================================= Coverage 64.80% 64.81% ======================================= Files 207 207 Lines 20153 20150 -3 ======================================= Hits 13060 13060 + Misses 5978 5976 -2 + Partials 1115 1114 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
alessio-perugini
approved these changes
Nov 8, 2023
umbynos
umbynos
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Removes the gRPC
settingsservice, and migrates the RPC calls to thecommandservice.The service
cc.arduino.cli.settings.v1no longer exists and all existing RPC calls have been moved to thecc.arduino.cli.commands.v1service adding aSettingsprefix to the names of all messages. The existing RPC calls:rpc GetAll(GetAllRequest) returns (GetAllResponse)rpc Merge(MergeRequest) returns (MergeResponse)rpc GetValue(GetValueRequest) returns (GetValueResponse)rpc SetValue(SetValueRequest) returns (SetValueResponse)rpc Write(WriteRequest) returns (WriteResponse)rpc Delete(DeleteRequest) returns (DeleteResponse)are now renamed to:
rpc SettingsGetAll(SettingsGetAllRequest) returns (SettingsGetAllResponse)rpc SettingsMerge(SettingsMergeRequest) returns (SettingsMergeResponse)rpc SettingsGetValue(SettingsGetValueRequest) returns (SettingsGetValueResponse)rpc SettingsSetValue(SettingsSetValueRequest) returns (SettingsSetValueResponse)rpc SettingsWrite(SettingsWriteRequest) returns (SettingsWriteResponse)rpc SettingsDelete(SettingsDeleteRequest) returns (SettingsDeleteResponse)What is the current behavior?
No change
What is the new behavior?
No change
Does this PR introduce a breaking change, and is titled accordingly?
Yes.
Other information