-
-
Notifications
You must be signed in to change notification settings - Fork 422
feat: added exit codes for CLI daemon command errors
#2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: imperfection
Perceived defect in any part of project
topic: CLI
Related to the command line interface
labels
Nov 3, 2023
@cmaglie
cmaglie
requested review from
kittaakos,
alessio-perugini,
umbynos and
MatteoPologruto
November 3, 2023 09:32
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #2400 +/- ## ========================================== + Coverage 64.58% 64.61% +0.03% ========================================== Files 207 207 Lines 19634 19634 ========================================== + Hits 12681 12687 +6 + Misses 5863 5859 -4 + Partials 1090 1088 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
3 tasks
umbynos
umbynos
approved these changes
Nov 3, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Makes the
daemoncommand return a consistent exit code for specific errors.What is the current behavior?
The exit code was a bit random:
What is the new behavior?
The following error codes have been added:
8: CLI failed to open a TCP port to listen for incoming connections9: TCP port argument is not validDoes this PR introduce a breaking change, and is titled accordingly?
Other information
Related to #2352