-
-
Notifications
You must be signed in to change notification settings - Fork 422
Replace mitchellh/go used for macOS notarization
#2399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c631ea to
cbbd85c
Compare
@ubidefeo
ubidefeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on Ventura, no issues with running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs fine if launched from command-line ternimal.
It won't start if double-clicked from file manager and it has quarantine flags set (but the same happens with old releases so I think it's fine?)
* switch to gon fork, apple is deprecating altool to sign * Provider is mandatory
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
change in tooling see arduino/tooling-project-assets#359
What is the current behavior?
An excellent tool named gon was used to perform the notarization.
the latest stable release of gon uses the altool command-line utility for notarization:
https://github.com/mitchellh/gon/blob/v0.2.5/notarize/upload.go#L41
Using altool for notarization is now deprecated by Apple and support for notarization via this tool is scheduled to be disabled 2023年11月01日:
https://developer.apple.com/news/?id=y5mjxqmn
Furthermore, gon was archived
What is the new behavior?
I switched to https://github.com/Bearer/gon that has included mitchellh/gon#72, hoping the maintainers will take the responsibility of maintaining the project.
I added also
AC_PROVIDERenv var which is mandatory with the newnotarytool.Does this PR introduce a breaking change, and is titled accordingly?
no
Other information