-
-
Notifications
You must be signed in to change notification settings - Fork 422
Added {sketch_path}
to build properties
#2372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: imperfection
Perceived defect in any part of project
topic: build-process
Related to the sketch build process
labels
Oct 17, 2023
@cmaglie
cmaglie
requested review from
alessio-perugini,
per1234,
umbynos and
MatteoPologruto
October 17, 2023 13:59
@cmaglie
cmaglie
changed the title
(削除) Added 'sketch_path' to build properties (削除ここまで)
(追記) Added Oct 17, 2023
{sketch_path}
to build properties (追記ここまで)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #2372 +/- ## ======================================= Coverage 62.81% 62.82% ======================================= Files 204 204 Lines 19308 19311 +3 ======================================= + Hits 12129 12132 +3 Misses 6119 6119 Partials 1060 1060
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
alessio-perugini
approved these changes
Oct 17, 2023
umbynos
umbynos
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Adds the missing
sketch_path
variable to the build properties.What is the current behavior?
{sketch_path}
is missing from the build properties:What is the new behavior?
{sketch_path}
is present in the build properties:Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #2340