-
-
Notifications
You must be signed in to change notification settings - Fork 422
Porting legacy tests to new integration-test infra (part 4...)
#2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@ ## master #2315 +/- ## ========================================== - Coverage 63.66% 63.29% -0.37% ========================================== Files 204 202 -2 Lines 19735 19204 -531 ========================================== - Hits 12564 12156 -408 + Misses 6082 6017 -65 + Partials 1089 1031 -58
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@alessio-perugini
alessio-perugini
force-pushed
the
refactor_legacy_test_part4
branch
from
September 14, 2023 07:34
2190367 to
f5230a2
Compare
@alessio-perugini
alessio-perugini
added
the
topic: code
Related to content of the project itself
label
Sep 14, 2023
@alessio-perugini
alessio-perugini
marked this pull request as ready for review
September 14, 2023 10:14
@alessio-perugini
alessio-perugini
changed the title
(削除) [skip-changelog] Porting legacy tests to new integration-test infra (part4) (削除ここまで)
(追記) Porting legacy tests to new integration-test infra (part 4...) (追記ここまで)
Sep 15, 2023
@alessio-perugini
alessio-perugini
changed the title
(削除) Porting legacy tests to new integration-test infra (part 4...) (削除ここまで)
(追記) Porting Sep 15, 2023
legacy tests to new integration-test infra (part 4...) (追記ここまで)
cmaglie
cmaglie
approved these changes
Sep 15, 2023
@alessio-perugini
alessio-perugini
force-pushed
the
refactor_legacy_part5
branch
from
September 15, 2023 15:58
1239ab2 to
6004057
Compare
... from legacy into integration test
@cmaglie
cmaglie
force-pushed
the
refactor_legacy_test_part4
branch
from
September 15, 2023 16:17
e799bad to
1a6d693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information