Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

cli/config get #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ardnew wants to merge 2 commits into arduino:master from ardnew:cli/config-get
Closed

cli/config get #2306

ardnew wants to merge 2 commits into arduino:master from ardnew:cli/config-get

Conversation

Copy link
Contributor

@ardnew ardnew commented Sep 10, 2023

cmaglie and others added 2 commits August 31, 2023 12:49
* If the upload port-detector fails detection, fallback to the user-provided port
This will ensure that a port is always returned.
* Increased debug level
* Extend timeout if candidate port is lost in any case
Even if `waitForUploadPort` is true, we should extend the timeout to
allow USB enumeration to complete. In this case we extend by only 1
second instead of 5.
* Revert "Extend timeout if candidate port is lost in any case"
This reverts commit 7c77ed2.
The latest commit is not necessary since the detector has already 5 seconds of timeout.
Copy link
Contributor Author

ardnew commented Sep 10, 2023

Accidentally included 048415c with this PR, closing and trying again

@per1234 per1234 self-assigned this Sep 10, 2023
@per1234 per1234 added conclusion: duplicate Has already been submitted type: enhancement Proposed improvement topic: code Related to content of the project itself topic: CLI Related to the command line interface labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
conclusion: duplicate Has already been submitted topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /