-
-
Notifications
You must be signed in to change notification settings - Fork 423
regression: Import fix for compile --input-dir . regression found in #2304
#2305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for default profile to compile command * Add support for default profiles to upload command * Add TestCompileWithDefaultProfile to integration tests * Get the profile's FQBN if it's not already specified in the request * Update documentation regarding sketch projects * Added integration tests for all default_profile cases * Reverted old sketch_with_profile test --------- Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
...Port` in `GetPort` (arduino#2297) * Change GetPort's returned type to rpc.Port * Use LoadSketch in runUploadCommand
@cmaglie
cmaglie
added
type: imperfection
Perceived defect in any part of project
topic: CLI
Related to the command line interface
labels
Sep 8, 2023
@cmaglie
cmaglie
requested review from
umbynos,
MatteoPologruto and
alessio-perugini
September 8, 2023 14:56
umbynos
umbynos
approved these changes
Sep 8, 2023
alessio-perugini
alessio-perugini
approved these changes
Sep 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## 0.34.x #2305 +/- ## ========================================== - Coverage 63.22% 63.02% -0.21% ========================================== Files 221 221 Lines 19747 19769 +22 ========================================== - Hits 12485 12459 -26 - Misses 6164 6201 +37 - Partials 1098 1109 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
The regression has already been fixed as part of another refactoring:
LoadSketchin upload function and returnrpc.PortinGetPort#2297This PR cherry-picks the fix in the current 0.34.x branch to release a
0.34.2.What is the current behavior?
arduino-cli compile ... --input-dir .crashes instead of uploading.Please have a look at #2304 for details.
What is the new behavior?
Upload works as expected.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fix #2304