-
-
Notifications
You must be signed in to change notification settings - Fork 422
feature: Added gRPC close signal to Monitor call (allows graceful close of monitor)
#2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: gRPC
Related to the gRPC interface
labels
Aug 23, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #2276 +/- ## ========================================== + Coverage 68.71% 68.85% +0.13% ========================================== Files 204 204 Lines 20446 20465 +19 ========================================== + Hits 14050 14091 +41 + Misses 5251 5220 -31 - Partials 1145 1154 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
@cmaglie
cmaglie
force-pushed
the
monitor_close_grpc
branch
from
October 25, 2023 12:49
cb832d7 to
a827eaf
Compare
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
October 26, 2023 16:33
alessio-perugini
alessio-perugini
approved these changes
Oct 26, 2023
@cmaglie
cmaglie
force-pushed
the
monitor_close_grpc
branch
from
December 28, 2023 13:45
2d33dec to
9534e2c
Compare
... check for a specific error
@cmaglie
cmaglie
force-pushed
the
monitor_close_grpc
branch
from
January 2, 2024 10:27
9534e2c to
094e3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Adds a
closefeature to the gRPCMonitorcall. This new feature allows the client to gracefully close the port monitor.What is the current behavior?
To close a gRPC-opened monitor, the client must close the gRPC streaming call, BTW this creates a race condition: the client is not aware of when the connection to the port is actually closed by the daemon afterward.
See #2271 for details.
What is the new behavior?
The
closemessage should allow to gracefully close the monitor.Does this PR introduce a breaking change, and is titled accordingly?
Yes, the gRPC
Monitorcall has been refactored to use a better description of the gRPC message based on theoneofdescriptor.Other information
Fix #2271