-
-
Notifications
You must be signed in to change notification settings - Fork 422
Allow .cxx and .cc extension in compile
#2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: build-process
Related to the sketch build process
labels
Aug 22, 2023
@cmaglie
cmaglie
requested review from
alessio-perugini,
umbynos and
MatteoPologruto
August 22, 2023 14:13
@cmaglie
cmaglie
force-pushed
the
allow_cxx_and_cc
branch
from
August 22, 2023 14:22
dbd1189 to
c4d27be
Compare
alessio-perugini
alessio-perugini
approved these changes
Aug 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #2273 +/- ## ======================================= Coverage 62.98% 62.99% ======================================= Files 221 221 Lines 19746 19749 +3 ======================================= + Hits 12438 12441 +3 Misses 6206 6206 Partials 1102 1102
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
umbynos
umbynos
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Allows compilation to build also
.cxxand.ccfiles.In theory, the platforms should provide a recipe for compiling
cxxandccspecifically, but this implementation reuses the recipe for.cppas a fallback if the specific recipes are missing (that is the situation for basically all the platforms in the existence, and it is unlikely to change in the future).What is the current behavior?
.cxxand.ccfiles are ignored.What is the new behavior?
.cxxand.ccfiles are compiled.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #1149