-
-
Notifications
You must be signed in to change notification settings - Fork 422
Added --no-check-for-updates in version command
#2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #2272 +/- ## ========================================== + Coverage 62.93% 62.98% +0.04% ========================================== Files 221 221 Lines 19730 19748 +18 ========================================== + Hits 12418 12439 +21 + Misses 6209 6207 -2 + Partials 1103 1102 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Question: can't it already be achieved by setting updater.enable_notification to false? #2055
no, version ignores that flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @MatteoPologruto is right, it was fixed in #2055
❰umberto❙~/Nextcloud/8tb/Lavoro/arduino-cli(git≠master)❱✔≻ arduino-cli config set updater.enable_notification true
❰umberto❙~/Nextcloud/8tb/Lavoro/arduino-cli(git≠master)❱✔≻ rm ~/.arduino15/inventory.yaml
❰umberto❙~/Nextcloud/8tb/Lavoro/arduino-cli(git≠master)❱✔≻ time arduino-cli version
arduino-cli Version: 0.33.1 Commit: 347bfeb0 Date: 2023年06月30日T15:32:47Z
________________________________________________________
Executed in 919.12 millis fish external
usr time 49.31 millis 1.35 millis 47.95 millis
sys time 38.81 millis 0.45 millis 38.36 millis
❰umberto❙~/Nextcloud/8tb/Lavoro/arduino-cli(git≠master)❱✔≻ arduino-cli config set updater.enable_notification false
❰umberto❙~/Nextcloud/8tb/Lavoro/arduino-cli(git≠master)❱✔≻ rm ~/.arduino15/inventory.yaml
❰umberto❙~/Nextcloud/8tb/Lavoro/arduino-cli(git≠master)❱✔≻ time arduino-cli version
arduino-cli Version: 0.33.1 Commit: 347bfeb0 Date: 2023年06月30日T15:32:47Z
________________________________________________________
Executed in 37.48 millis fish external
usr time 16.05 millis 1.10 millis 14.94 millis
sys time 10.34 millis 0.38 millis 9.96 millis
You're right 🤔, apologies guys.
Actually, it's also possible to override it with the env var ARDUINO_UPDATER_ENABLE_NOTIFICATION=false:
ARDUINO_UPDATER_ENABLE_NOTIFICATION=false ./arduino-cli version
so, @kittaakos I think you're all set with the current Arduino CLI, no need to patch it :-)
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Adds the new flag
--no-check-for-updatesthat disable the automatic check for new versions in theversioncommand and print the current version without any delay.What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information