-
-
Notifications
You must be signed in to change notification settings - Fork 422
Removed useless version param on 'core uninstall' #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be removed:
arduino-cli/daemon/client/client.go
Line 345 in 982a271
This line:
arduino-cli/cli/core/uninstall.go
Line 35 in 982a271
Should be changed to:
Use: "uninstall PACKAGER:ARCH ...",
71a8b57 to
4b59605
Compare
✅ Build completed.
⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-linux64.tar.bz2
⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-linux32.tar.bz2
⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-linuxarm.tar.bz2
⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-windows.zip
⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-59-PR224-osx.zip
i️ To test this build:
- Just replace
arduino-clibinary with the provided one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't actually test this due to the issue I reported in CLI-15, but I am satisfied that my requested changes were made. Thanks!
Run Go module configuration sync check also on docsgen module
/cc @per1234