-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix double 100% progress on CompileResponse #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alessio-perugini
alessio-perugini
added
the
type: imperfection
Perceived defect in any part of project
label
Jun 23, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #2225 +/- ## ========================================== - Coverage 62.97% 62.95% -0.02% ========================================== Files 220 220 Lines 19501 19538 +37 ========================================== + Hits 12280 12300 +20 - Misses 6137 6149 +12 - Partials 1084 1089 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@alessio-perugini
alessio-perugini
linked an issue
Jun 23, 2023
that may be
closed
by this pull request
3 tasks
@alessio-perugini
alessio-perugini
force-pushed
the
improve-compile-response-pb
branch
2 times, most recently
from
June 23, 2023 13:05
a9f606c to
c7a7212
Compare
@alessio-perugini
alessio-perugini
added
topic: code
Related to content of the project itself
topic: CLI
Related to the command line interface
labels
Jul 17, 2023
umbynos
umbynos
approved these changes
Aug 3, 2023
cmaglie
cmaglie
requested changes
Aug 3, 2023
cmaglie
cmaglie
approved these changes
Aug 3, 2023
...tly handle the substeps
@alessio-perugini
alessio-perugini
force-pushed
the
improve-compile-response-pb
branch
from
August 3, 2023 14:01
6442ed0 to
d1a7a6a
Compare
@alessio-perugini
alessio-perugini
deleted the
improve-compile-response-pb
branch
August 3, 2023 15:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fixes double 100% status on task upgrade when compiling
What is the current behavior?
Right now the
buildercommand calls therunCommands2 times which leads to having 2 100% values.What is the new behavior?
The new behavior only sends 1 100% task status and
completedproperty at true when done. I intentionally didn't try to refactor this legacy component.Does this PR introduce a breaking change, and is titled accordingly?
Other information