Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[skip-changelog] Fix failing board tests #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoPologruto merged 2 commits into arduino:master from MatteoPologruto:fix-failing-tests
Jun 21, 2023

Conversation

Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Jun 21, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Code imperfection fix

What is the current behavior?

Some board tests are failing.

What is the new behavior?

TestBoardSearch has been updated to match the changes in the package index. TestBoardListWithInvalidDiscovery has been removed because it's a duplicate of TestBoardListWithFailedBuiltinInstallation, with the latter being more recent.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 21, 2023
@MatteoPologruto MatteoPologruto marked this pull request as ready for review June 21, 2023 08:53
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (223d3fa) 62.99% compared to head (2586641) 62.92%.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
- Coverage 62.99% 62.92% -0.07% 
==========================================
 Files 220 220 
 Lines 19477 19481 +4 
==========================================
- Hits 12269 12258 -11 
- Misses 6128 6139 +11 
- Partials 1080 1084 +4
Flag Coverage Δ
unit 62.92% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/sketch/new.go 85.71% <100.00%> (+1.50%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatteoPologruto MatteoPologruto merged commit ffb3d2f into arduino:master Jun 21, 2023
@MatteoPologruto MatteoPologruto deleted the fix-failing-tests branch June 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

@umbynos umbynos Awaiting requested review from umbynos

1 more reviewer

@alessio-perugini alessio-perugini alessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /