-
-
Notifications
You must be signed in to change notification settings - Fork 422
Use the same property name for the query term in search requests #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MatteoPologruto
merged 2 commits into
arduino:master
from
MatteoPologruto:query-term-name
Jun 14, 2023
Merged
Use the same property name for the query term in search requests #2214
MatteoPologruto
merged 2 commits into
arduino:master
from
MatteoPologruto:query-term-name
Jun 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MatteoPologruto
MatteoPologruto
added
type: enhancement
Proposed improvement
topic: gRPC
Related to the gRPC interface
labels
Jun 14, 2023
@MatteoPologruto
MatteoPologruto
requested review from
cmaglie,
alessio-perugini and
umbynos
June 14, 2023 16:04
@MatteoPologruto
MatteoPologruto
linked an issue
Jun 14, 2023
that may be
closed
by this pull request
3 tasks
cmaglie
cmaglie
approved these changes
Jun 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #2214 +/- ## ========================================== - Coverage 62.98% 62.93% -0.06% ========================================== Files 218 218 Lines 19466 19469 +3 ========================================== - Hits 12261 12252 -9 - Misses 6122 6131 +9 - Partials 1083 1086 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
gRPC enhancement
What is the current behavior?
Search requests use different properties for the query term:
What is the new behavior?
The
queryproperty inLibSearchRequesthas been deprecated.search_argsshould be used in its place.Does this PR introduce a breaking change, and is titled accordingly?
No