-
-
Notifications
You must be signed in to change notification settings - Fork 422
Interpret "empty" gRPC Port object as no-port in upload #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #2202 +/- ## ========================================== + Coverage 62.78% 62.80% +0.02% ========================================== Files 219 219 Lines 19469 19469 ========================================== + Hits 12224 12228 +4 + Misses 6159 6156 -3 + Partials 1086 1085 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes arduino/arduino-ide#2089
Thanks for your work on this and the previous #2173 Cristian!
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Makes the gRPC Upload command more relaxed in interpreting the "Port" object as a no port upload.
What is the current behavior?
An empty gRPC Port (with
AddressandProtocolset to the empty string) will make the upload fail. The same upload request will work as expected if the gRPC Port is leftnil/undefined.What is the new behavior?
An empty gRPC Port is treated the same as a
nil/undefined Port.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information