fix: Allow build-path to be in a different drive than current sketch #2163

The PR has no duplicates (please search among the Pull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This issue is mainly seen on Windows.

What is the current behavior?

(copied from original issue: #2156)

$ arduino-cli sketch new "e:/FooSketch"
Sketch created in: e:\FooSketch
$ arduino-cli compile --build-path "c:/Users/per/AppData/Local/Temp/build-path" --fqbn arduino:avr:uno "e:/FooSketch"
Error during build: Cannot find build path: Rel: can't make c:\Users\per\AppData\Local\Temp\build-path relative to E:\FooSketch

What is the new behavior?

Compiles succeed as expected.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

The actual patch is here: arduino/go-paths-helper#20

Fix #2156

@cmaglie cmaglie added topic: code type: imperfection topic: build-process labels

Apr 28, 2023

@cmaglie cmaglie requested review from alessio-perugini, per1234 and umbynos

April 28, 2023 15:58

@cmaglie cmaglie self-assigned this

Apr 28, 2023

@cmaglie cmaglie changed the title ~~(削除) fix: Allow build-path to different drive than the sketch (削除ここまで)~~ (追記) fix: Allow build-path to be in a different drive than current sketch (追記ここまで)

Apr 28, 2023

@cmaglie


 fix: Allow build-path to different drive than the sketch

6836ad6

This issue is mainly seen on Windows
Fix arduino#2156

@cmaglie cmaglie force-pushed the fix-build-on-different-drives branch from 5ace34f to 6836ad6 Compare

April 28, 2023 15:59

@codecov

Copy link

codecov bot commented Apr 28, 2023 •

edited

Loading

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.02 🎉

Comparison is base (ad9ddb8) 62.49% compared to head (6836ad6) 62.51%.

Additional details and impacted files

@@ Coverage Diff @@
## master #2163 +/- ##
==========================================
+ Coverage 62.49% 62.51% +0.02% 
==========================================
 Files 223 223 
 Lines 19472 19462 -10 
==========================================
- Hits 12169 12167 -2 
+ Misses 6205 6201 -4 
+ Partials 1098 1094 -4

Flag	Coverage Δ
unit	`62.51% <60.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
arduino/sketch/sketch.go	`79.31% <0.00%> (ø)`
commands/compile/compile.go	`69.56% <50.00%> (+1.24%)`	⬆️
arduino/cores/packagemanager/install_uninstall.go	`54.42% <100.00%> (+0.08%)`	⬆️