Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Compile on freebsd #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 1 commit into arduino:master from mojadita:feat/freebsd_support
Mar 22, 2023
Merged

Compile on freebsd #2116

cmaglie merged 1 commit into arduino:master from mojadita:feat/freebsd_support
Mar 22, 2023

Conversation

Copy link
Contributor

@mojadita mojadita commented Mar 18, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Allows to build the software in freebsd.

What is the current behavior?

On building you get an error on using the default (unimplemented) method for the two new files.

What is the new behavior?

It builds Ok. A link from the linux versions with _freebsd.go suffix has been created. Internally the call used in freebsd is the same as the one used in linux.

Does this PR introduce a breaking change, and is titled accordingly?

I don't think so.

Other information

N.A.

Copy link

codecov bot commented Mar 18, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (5f03cb9) 34.95% compared to head (db6d63d) 34.96%.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2116 +/- ##
==========================================
+ Coverage 34.95% 34.96% +0.01% 
==========================================
 Files 232 232 
 Lines 20570 20570 
==========================================
+ Hits 7190 7193 +3 
+ Misses 12531 12529 -2 
+ Partials 849 848 -1
Flag Coverage Δ
unit 34.96% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

 

Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>
@cmaglie cmaglie self-assigned this Mar 22, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 22, 2023
@cmaglie cmaglie merged commit 2900744 into arduino:master Mar 22, 2023
@per1234 per1234 added the os: linux Specific to Linux operating system label Mar 28, 2023
@per1234 per1234 mentioned this pull request Mar 28, 2023
3 tasks
@cmaglie cmaglie mentioned this pull request Apr 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Labels
os: linux Specific to Linux operating system topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /