Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: option to expand properties with flag --show-properties #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bikappa merged 6 commits into master from feat/expanded-show-properties
Feb 17, 2023

Conversation

Copy link
Contributor

@Bikappa Bikappa commented Feb 13, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Introduce a variant of the --show-properties command line flag. It now accepts two values:

  • pattern(default when a value is not specified) which corresponds to the previous behavior of the flag
  • expanded which replaces the placeholders in the output build properties with the corresponding context values.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Fixes #1046

Copy link

codecov bot commented Feb 13, 2023 •
edited
Loading

Codecov Report

Base: 36.64% // Head: 36.58% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (c4bce47) compared to base (53a6f25).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
- Coverage 36.64% 36.58% -0.07% 
==========================================
 Files 229 229 
 Lines 19471 19504 +33 
==========================================
 Hits 7135 7135 
- Misses 11498 11531 +33 
 Partials 838 838
Flag Coverage Δ
unit 36.58% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/cli/compile/compile.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bikappa Bikappa added the topic: code Related to content of the project itself label Feb 13, 2023
@Bikappa Bikappa marked this pull request as draft February 14, 2023 08:56
@Bikappa Bikappa force-pushed the feat/expanded-show-properties branch 7 times, most recently from c4f7210 to a9cc2f2 Compare February 14, 2023 13:29
@Bikappa Bikappa force-pushed the feat/expanded-show-properties branch from a9cc2f2 to 647d629 Compare February 14, 2023 13:35
@Bikappa Bikappa marked this pull request as ready for review February 14, 2023 14:02
@Bikappa Bikappa self-assigned this Feb 14, 2023
@Bikappa Bikappa force-pushed the feat/expanded-show-properties branch from ec60d63 to c4bce47 Compare February 17, 2023 15:49
@Bikappa Bikappa merged commit a1e69dc into master Feb 17, 2023
@Bikappa Bikappa deleted the feat/expanded-show-properties branch February 17, 2023 16:04
@per1234 per1234 added the type: enhancement Proposed improvement label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@per1234 per1234 Awaiting requested review from per1234

@umbynos umbynos Awaiting requested review from umbynos

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: arduino-cli compile --show-properties option to show fully expanded properties

AltStyle によって変換されたページ (->オリジナル) /