-
-
Notifications
You must be signed in to change notification settings - Fork 422
Add infrastructure for validating JSON schemas #2073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A task and GitHub Actions workflow is added here to validate JSON schema files against the meta-schema. On every push or pull request that affects the repository's JSON schema files, and periodically, the workflow will automatically validate the schemas.
Codecov ReportBase: 36.66% // Head: 36.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## chore/json-schema #2073 +/- ## ===================================================== + Coverage 36.66% 36.68% +0.01% ===================================================== Files 228 228 Lines 19385 19385 ===================================================== + Hits 7108 7111 +3 + Misses 11444 11442 -2 + Partials 833 832 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
34c68ce to
99eb639
Compare
Superseded by Go-based validation added as part of #2073
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the current behavior?
There is no validation of the Arduino CLI configuration file JSON schema. This will increase the burden on contributors to the schema and the reviewers of those contributions.
What is the new behavior?
A task and GitHub Actions workflow is added here to validate JSON schema files against the meta-schema.
On every push or pull request that affects the repository's JSON schema files, and periodically, the workflow will automatically validate the schemas.
The workflow is designed to allow expansion to validation of any number of JSON schemas that might be added to the repository in the future (we had some tentative plans to move the schemas from the Arduino Lint repository to this repo).
Does this PR introduce a breaking change, and is titled accordingly?
No breaking change.