Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: sketch name validation error messages #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bikappa merged 5 commits into master from fix/sketch-name-validation
Feb 6, 2023

Conversation

Copy link
Contributor

@Bikappa Bikappa commented Feb 2, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Follow up on #2051. Fixing the error messages returned when validating the sketch name

What is the current behavior?

Errors are difficult to understand

What is the new behavior?

Errors are more human readable

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Copy link

codecov bot commented Feb 2, 2023 •
edited
Loading

Codecov Report

Base: 36.67% // Head: 36.76% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (b1aacff) compared to base (2b8d6d7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2059 +/- ##
==========================================
+ Coverage 36.67% 36.76% +0.08% 
==========================================
 Files 228 228 
 Lines 19384 19383 -1 
==========================================
+ Hits 7110 7126 +16 
+ Misses 11442 11429 -13 
+ Partials 832 828 -4
Flag Coverage Δ
unit 36.76% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/sketch/new.go 68.42% <100.00%> (-0.81%) ⬇️
arduino/cores/packagemanager/package_manager.go 68.19% <0.00%> (+0.72%) ⬆️
arduino/errors.go 4.44% <0.00%> (+0.74%) ⬆️
arduino/monitor/monitor.go 47.36% <0.00%> (+6.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bikappa Bikappa force-pushed the fix/sketch-name-validation branch from e511fd7 to b1aacff Compare February 2, 2023 11:25
@Bikappa Bikappa marked this pull request as ready for review February 2, 2023 11:28
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 3, 2023
@Bikappa Bikappa merged commit 4c0aaa8 into master Feb 6, 2023
@Bikappa Bikappa deleted the fix/sketch-name-validation branch February 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /