Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: filter boards by fqbn in connected list #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bikappa merged 6 commits into master from feat/board-list-fqbn-filter
Jan 30, 2023

Conversation

Copy link
Contributor

@Bikappa Bikappa commented Jan 25, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Ability to restrict the board list output to the boards matching a specific FQBN.

What is the current behavior?

When listing connected boards, all discovered boards are returned without user-controlled filtering

What is the new behavior?

The user can specify an FQBN parameter, the resulting list contains all and only the boards matching the given FQBN.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Fixes #1068

obra reacted with heart emoji
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Base: 36.50% // Head: 36.48% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e07272f) compared to base (58c6bc3).
Patch coverage: 30.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
- Coverage 36.50% 36.48% -0.03% 
==========================================
 Files 228 228 
 Lines 19306 19343 +37 
==========================================
+ Hits 7048 7057 +9 
- Misses 11434 11461 +27 
- Partials 824 825 +1
Flag Coverage Δ
unit 36.48% <30.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/board/list.go 33.50% <0.00%> (-3.52%) ⬇️
internal/cli/board/list.go 0.00% <0.00%> (ø)
arduino/cores/fqbn.go 100.00% <100.00%> (ø)
commands/lib/search.go 88.15% <0.00%> (-3.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 26, 2023
@Bikappa Bikappa force-pushed the feat/board-list-fqbn-filter branch from b6bdf64 to 12caaa8 Compare January 26, 2023 12:58
@Bikappa Bikappa marked this pull request as ready for review January 26, 2023 14:08
@Bikappa Bikappa force-pushed the feat/board-list-fqbn-filter branch 2 times, most recently from 117bbd3 to 74441de Compare January 27, 2023 08:27
@Bikappa Bikappa force-pushed the feat/board-list-fqbn-filter branch from c8dd36d to e73a04d Compare January 27, 2023 15:47
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bikappa!

@Bikappa Bikappa merged commit cddbff3 into master Jan 30, 2023
@Bikappa Bikappa deleted the feat/board-list-fqbn-filter branch January 30, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@umbynos umbynos Awaiting requested review from umbynos

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: board list --fqbn?
2 participants

AltStyle によって変換されたページ (->オリジナル) /