Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fixed error message capitalization #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bikappa merged 1 commit into arduino:master from cushonz:fix-capitalization
Jan 24, 2023
Merged

Fixed error message capitalization #2048

Bikappa merged 1 commit into arduino:master from cushonz:fix-capitalization
Jan 24, 2023

Conversation

Copy link
Contributor

@cushonz cushonz commented Jan 23, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Simple syntax changes to error messages.

What is the current behavior?

Currently the message is incorrectly capitalized.

What is the new behavior?

Corrects capitalization on all "Libraries: " strings to "libraries: "

Does this PR introduce a breaking change, and is titled accordingly?

No, the changes made in this pull request are trivial and should not impact operation

Copy link

CLAassistant commented Jan 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 36.55% // Head: 36.55% // No change to project coverage 👍

Coverage data is based on head (7093067) compared to base (a58d5ad).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2048 +/- ##
=======================================
 Coverage 36.55% 36.55% 
=======================================
 Files 229 229 
 Lines 19383 19383 
=======================================
 Hits 7085 7085 
 Misses 11462 11462 
 Partials 836 836
Flag Coverage Δ
unit 36.55% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/cli/lib/list.go 0.00% <0.00%> (ø)
commands/lib/search.go 88.15% <0.00%> (-3.95%) ⬇️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 24, 2023
@per1234 per1234 linked an issue Jan 24, 2023 that may be closed by this pull request
3 tasks
@Bikappa Bikappa self-assigned this Jan 24, 2023
@Bikappa Bikappa self-requested a review January 24, 2023 11:29
@Bikappa Bikappa merged commit 1962996 into arduino:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Bikappa Bikappa Bikappa approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong error messages capitalization

AltStyle によって変換されたページ (->オリジナル) /