Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[breaking] Remove ip flag from daemon command #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoPologruto merged 2 commits into arduino:master from MatteoPologruto:remove-daemon-ip-flag
Jan 24, 2023

Conversation

Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Jan 23, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Code security improvement

What is the current behavior?

It is currently possible to use --ip to set a custom ip for listening to gRPC request.

What is the new behavior?

The --ip flag is removed and the default value is set to 127.0.0.1.

Does this PR introduce a breaking change, and is titled accordingly?

Yes

@MatteoPologruto MatteoPologruto added topic: security Related to the protection of user data topic: code Related to content of the project itself labels Jan 23, 2023
@MatteoPologruto MatteoPologruto linked an issue Jan 23, 2023 that may be closed by this pull request
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Base: 36.55% // Head: 36.56% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c829944) compared to base (1962996).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
+ Coverage 36.55% 36.56% +0.01% 
==========================================
 Files 229 229 
 Lines 19383 19383 
==========================================
+ Hits 7085 7088 +3 
+ Misses 11462 11460 -2 
+ Partials 836 835 -1
Flag Coverage Δ
unit 36.56% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/cli/daemon/daemon.go 0.00% <0.00%> (ø)
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a breaking change UPGRADING.md needs to be updates accordingly

per1234 reacted with heart emoji
@MatteoPologruto MatteoPologruto changed the title (削除) Remove ip flag from daemon command (削除ここまで) (追記) [breaking] Remove ip flag from daemon command (追記ここまで) Jan 24, 2023
@MatteoPologruto MatteoPologruto merged commit a63aff4 into arduino:master Jan 24, 2023
@MatteoPologruto MatteoPologruto deleted the remove-daemon-ip-flag branch January 24, 2023 16:37
@per1234 per1234 added the type: enhancement Proposed improvement label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself topic: security Related to the protection of user data type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove daemon --ip flag

AltStyle によって変換されたページ (->オリジナル) /