Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

refactoring: Fixing legacy pathnames #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 5 commits into arduino:master from cmaglie:fixing_legacy_pathnames
Jan 27, 2023

Conversation

Copy link
Member

@cmaglie cmaglie commented Jan 19, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Some changes and cleanup on the legacy wrt build paths.
There is a lot of redundancy in the legacy builder, this PR aims to remove all code duplication.

What is the current behavior?

No changes in behavior, this PR should be equivalent code change.

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No breaking changes

Other information

@cmaglie cmaglie self-assigned this Jan 19, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 19, 2023
Copy link

codecov bot commented Jan 19, 2023 •
edited
Loading

Codecov Report

Base: 36.56% // Head: 36.47% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (9fd565d) compared to base (a63aff4).
Patch coverage: 61.11% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
- Coverage 36.56% 36.47% -0.10% 
==========================================
 Files 229 228 -1 
 Lines 19383 19306 -77 
==========================================
- Hits 7088 7042 -46 
+ Misses 11460 11438 -22 
+ Partials 835 826 -9
Flag Coverage Δ
unit 36.47% <61.11%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/compile/compile.go 0.00% <0.00%> (ø)
...egacy/builder/add_additional_entries_to_context.go 62.50% <ø> (+1.97%) ⬆️
legacy/builder/builder.go 84.84% <ø> (+3.68%) ⬆️
legacy/builder/container_setup.go 85.71% <ø> (+2.07%) ⬆️
commands/debug/debug_info.go 45.04% <33.33%> (-1.75%) ⬇️
legacy/builder/types/context.go 73.52% <71.42%> (-1.17%) ⬇️
arduino/sketch/sketch.go 63.79% <100.00%> (-1.75%) ⬇️
commands/upload/upload.go 54.73% <100.00%> (ø)
...acy/builder/fail_if_buildpath_equals_sketchpath.go 100.00% <100.00%> (+50.00%) ⬆️
legacy/builder/setup_build_properties.go 85.86% <100.00%> (+2.36%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie force-pushed the fixing_legacy_pathnames branch from 9970e24 to 9fd565d Compare January 27, 2023 09:21
@cmaglie cmaglie marked this pull request as ready for review January 27, 2023 09:21
@cmaglie cmaglie merged commit 58c6bc3 into arduino:master Jan 27, 2023
@cmaglie cmaglie deleted the fixing_legacy_pathnames branch January 27, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Bikappa Bikappa Bikappa approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /