-
-
Notifications
You must be signed in to change notification settings - Fork 422
Improve board list detection via cloud API
#1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
@cmaglie
cmaglie
force-pushed
the
improve_api_query
branch
from
November 17, 2022 09:52
31467b6 to
7bbf2a2
Compare
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
priority: high
Resolution is a high priority
criticality: high
Of high impact
topic: code
Related to content of the project itself
labels
Nov 17, 2022
@cmaglie
cmaglie
requested review from
per1234,
MatteoPologruto,
ubidefeo and
umbynos
November 17, 2022 10:00
umbynos
umbynos
reviewed
Nov 18, 2022
umbynos
umbynos
reviewed
Nov 18, 2022
The `apiByVidPid` function now masks the odd behavior of the builder-api returning an HTTP 404 if the request succeed but the result is empty.
@cmaglie
cmaglie
force-pushed
the
improve_api_query
branch
from
November 18, 2022 13:51
5765a92 to
9c0c122
Compare
umbynos
umbynos
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
board listif the network is not available (fix Provide an--offlinedirective to prevent errors in portable mode #1963 )What is the current behavior?
board listterminate with an error if the network is not available and the board is not "known" (there are no platform installed for that board).What is the new behavior?
The
board listcommand always complete even if the network is not availableDoes this PR introduce a breaking change, and is titled accordingly?
No