-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix lib upgrade command not installing new libraries dependencies #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
cmaglie
requested changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to call LibraryInstall internally.
cmaglie
cmaglie
reviewed
Oct 21, 2022
@silvanocerza
silvanocerza
force-pushed
the
fix-lib-upgrade
branch
from
October 21, 2022 12:50
304c554 to
f4d8d91
Compare
@silvanocerza
silvanocerza
force-pushed
the
fix-lib-upgrade
branch
from
October 21, 2022 14:38
f4d8d91 to
e58a4d6
Compare
cmaglie
cmaglie
approved these changes
Oct 21, 2022
@cmaglie
cmaglie
added
type: imperfection
Perceived defect in any part of project
topic: package-management
Related to the packaging and managing of the platform/libraries
priority: high
Resolution is a high priority
criticality: medium
Of moderate impact
labels
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Bug fix on an existing command.
What is the current behavior?
Current behaviour is explained in issue #1856
What is the new behavior?
Calling
lib upgradenow will also install newly added dependencies to libraries being updated.This fixes also the gRPC interface commands
LibraryUpgradeAllandLibraryUpgrade.Does this PR introduce a breaking change, and is titled accordingly?
Nope.
Other information
Fixes #1856.
This PR depends on #1934.