-
-
Notifications
You must be signed in to change notification settings - Fork 422
[skip-changelog] Migrate tests from test_update.py to update_test.go
#1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MatteoPologruto
MatteoPologruto
added
type: enhancement
Proposed improvement
topic: infrastructure
Related to project infrastructure
labels
Oct 20, 2022
@MatteoPologruto
MatteoPologruto
marked this pull request as ready for review
October 20, 2022 15:41
...date_test.go and delete test_update.py
@MatteoPologruto
MatteoPologruto
force-pushed
the
update-test
branch
from
October 21, 2022 12:27
9120ec3 to
b99d879
Compare
umbynos
umbynos
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 Thanks Matteo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure Enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_update.pyhave been rewritten inupdate_test.go, without changing their original purpose.Does this PR introduce a breaking change, and is titled accordingly?
No