Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add task to collect proto files and add steps to release them with tester, nightly and stable builds #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umbynos merged 8 commits into arduino:master from silvanocerza:protoc-collection
Oct 25, 2022
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/publish-go-nightly-task.yml
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,15 @@ jobs:
name: ${{ env.ARTIFACT_NAME }}
path: ${{ env.DIST_DIR }}

- name: Install Task
uses: arduino/setup-task@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Collect proto files
run: task protoc:collect

- name: Create checksum file
working-directory: ${{ env.DIST_DIR}}
run: |
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/publish-go-tester-task.yml
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,35 @@ jobs:
with:
path: ./*checksums.txt
name: checksums

proto-files:
# Run this after checksums or the uploaded proto files zip
# will make the checksum job always fail
needs:
- checksums
- package-name-prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why checksums is failing? shouldn't just add the checksum of the protoc archive to the checksums file together with the other archives?

Copy link
Contributor Author

@silvanocerza silvanocerza Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about that, it would make sense since it's a file part of the release. 🤔
I'd have to edit a bit the checksum process I think, I'll take a look at it.

umbynos reacted with eyes emoji
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Install Task
uses: arduino/setup-task@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Collect proto files
run: |
PACKAGE_NAME_PREFIX=${{ needs.package-name-prefix.outputs.prefix }}
export PACKAGE_NAME_PREFIX
task protoc:collect

- name: Upload proto files zip
uses: actions/upload-artifact@v3
with:
path: ${{ env.DIST_DIR }}/*.zip
name: rpc-protocol-files
9 changes: 9 additions & 0 deletions .github/workflows/release-go-task.yml
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,15 @@ jobs:
unzip -p /tmp/3.0.0.zip semver-tool-3.0.0/src/semver >/tmp/semver && chmod +x /tmp/semver
if [[ "$(/tmp/semver get prerel ${{ needs.create-release-artifacts.outputs.version }} )" ]]; then echo "::set-output name=IS_PRE::true"; fi

- name: Install Task
uses: arduino/setup-task@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Collect proto files
run: task protoc:collect

- name: Create Github Release and upload artifacts
uses: ncipollo/release-action@v1
with:
Expand Down
7 changes: 7 additions & 0 deletions Taskfile.yml
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,13 @@ tasks:
cmds:
- buf lint rpc

protoc:collect:
desc: Create a zip file containing all .proto files in DIST_DIR
dir: rpc
cmds:
- mkdir ../{{.DIST_DIR}}
- zip -r ../{{.DIST_DIR}}/{{.PROJECT_NAME}}_{{.VERSION}}_proto.zip * -i \*.proto

protoc:format:
desc: Perform formatting of the protobuf definitions
cmds:
Expand Down

AltStyle によって変換されたページ (->オリジナル) /